Skip to main content

Tickets, PRs and DTAP

You, as a developer, are responsible to get your ticket closed - not the team lead, not the project manager - so you are responsible for keeping things in motion / following things up if things gets stuck at some stage in this process.

Proactively ask for help via Slack if you have any questions of course!

Stages​

  • Development - you and your developer colleagues can test on your local machine
  • Test - optional staging environment to share changes with non-developers before sharing things outside the team (not applicable to all projects)
  • Acceptance - main staging environment when all testing is done to get approval from a project manager / product owner before going live
  • Production - the live environment

👨🏻‍💻 Develop and test (D)​

Test your changes locally and make sure code is compliant with our standards, so:

  • No (new) type or lint warnings on lines of code you touched
  • Documentation is consulted for articles / pages that are relevant for your changes
Documentation unclear, outdated or incorrect?

Any documentation that is unclear or incorrect should be discussed with other developers immediately, but should not be blocking for creating a PR per se

🏋️‍♂️ Create a Pull request (T)​

  • Make sure the PR has a clear description of what the change is about, and include screenshots / gif screen recording if helpful for reviewers - this is to help reviewers know what to review and make sure the right people are involved in the review (developers can have different areas of expertise / domain knowledge)
  • Get some Code Reviews
    • Make sure to also discuss with team members what needs to be tested (team members / team lead can have a broader picture of what impact your changes could have on a website or platform)
    • Add a checklist of what's tested and what still needs to be tested in PR description
Test environment (not applicable to all projects)

Deploy your branch to the Test environment so non-devs can test/review as well (i.e: designer, tester, etc) - can be simultaneous with getting reviews

🧑🏻‍🚀 Merge the PR (A)​

The team lead will merge your PR (when you have all approvals needed to merge and all required testing is completed)

  • The team lead will deploy the latest version of the project to the staging environment (also known as "Acceptance" in DTAP)
    • Share the changes on the staging environment with your team lead and the Project manager at DOD

🚀 Close the ticket (P)​

Close ticket when:

  • Project manager confirms all work within ticket is done
  • work is merged to master/main branch and
  • deployment to Production environment (live site) was successful
Your first commit

✒️ Writing commit messages